chore: bump cli version for all apps #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pantani
requested review from
ilgooz,
jeronimoalbi,
julienrbrt and
Ehsan-saradar
as code owners
julienrbrt
reviewed
Dec 13, 2023
|
|
||
| ## lint: Run Golang CI Lint. | ||
| lint: | ||
| @echo Running golangci-lint... | ||
| @go run github.com/golangci/golangci-lint/cmd/golangci-lint run --out-format=tab --issues-exit-code=0 | ||
| @go list -f '{{.Dir}}/...' -m | xargs go run github.com/golangci/golangci-lint/cmd/golangci-lint run --out-format=tab --issues-exit-code=0 |
There was a problem hiding this comment.
We can do golangci-lint run ./... <args>, which is easier to read.
There was a problem hiding this comment.
I tried this way, but it always threw me an error after the command. I also added this way because other commands use the same pattern
| @@ -8,9 +8,14 @@ The app adds `ignite relayer hermes` commands to allow IBC communication between | |||
|
|
|||
| - Run both chain to be relayed. | |||
|
|
|||
| - add the hermes relayer app: | |||
| - add the hermes relayer app from remote: | |||
There was a problem hiding this comment.
Maybe "install" instead of "add":
Suggested change
| - add the hermes relayer app from remote: | |
| - install the Hermes relayer app from a remote repository: |
Comment on lines
+16
to
+18
| - or clone the repo and add the hermes relayer app local: | ||
| ```shell | ||
| ignite app install -g $GOPATH/src/github.com/ignite/apps/hermes |
There was a problem hiding this comment.
Maybe something similar to this that uses "install" instead of "add":
Suggested change
| - or clone the repo and add the hermes relayer app local: | |
| ```shell | |
| ignite app install -g $GOPATH/src/github.com/ignite/apps/hermes | |
| - or clone the repository and install the Hermes relayer app from a local directory: | |
| ```shell | |
| ignite app install -g PATH/TO/LOCAL/apps/hermes |
jeronimoalbi
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
v28;tool.gofile in the integration folder;Makefilecommands;make format;