Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1908 : HtsgetReader should not send HTSGet ticket server headers in data server requests #1909

Merged
merged 2 commits into from
Nov 1, 2024
Merged

1908 : HtsgetReader should not send HTSGet ticket server headers in data server requests #1909

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d91572
htsget_ticket_server_headers_should_NOT_be_sent_in_data_requests: onl…
andycameronGEL Oct 9, 2024
9627656
only set data url headers for htsget options
andycameronGEL Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions js/htsget/htsgetReader.js
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be just

const options = {headers: urlData.headers || {})

Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,7 @@ class HtsgetReader {
promiseArray.push(Promise.resolve(dataUriToBytes(urlData.url)))

} else {

const options = buildOptions(this.config || {})

if (urlData.headers) {
options.headers = Object.assign(options.headers || {}, urlData.headers)
}

const options = {headers: urlData.headers || {}}
promiseArray.push(igvxhr.loadArrayBuffer(urlData.url, options))
}
}
Expand Down
Loading