Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm unnecessary try/catch block around the Ilios client instantiation. #26

Merged
merged 1 commit into from
Oct 14, 2024
Merged

rm unnecessary try/catch block around the Ilios client instantiation. #26

merged 1 commit into from
Oct 14, 2024

Commits on Oct 11, 2024

  1. rm unnecessary try/catch block around the Ilios client instantiation. 

    the only thing that would cause an exception to get thrown in the
constructor of the Ilios client class would be emitted out of the
Moodle-core get_config() method. which would only occur if we tried to
read plugin config during system installation. we're not doing this
here, so let's get rid of it.
as a positive side-effect, this also eliminates the need to correct the incorrect
position of the chained re-thrown exception that's  being passed into
the Exception constructor.

while at it, i moved the client instantiation out of the try/catch block
in the new sync job form. should make it clearer what we're actually
tring to catch there.
    @stopfstedt
    stopfstedt committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    31ae556 View commit details
    Browse the repository at this point in the history