rm unnecessary try/catch block around the Ilios client instantiation. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the only thing that would cause an exception to get thrown in the constructor of the Ilios client class would be emitted out of the Moodle-core get_config() method. which would only occur if we tried to read plugin config during system installation. we're not doing this here, so let's get rid of it. as a positive side-effect, this also eliminates the need to correct the incorrect position of the chained re-thrown exception that's being passed into the Exception constructor. while at it, i moved the client instantiation out of the try/catch block in the new sync job form. should make it clearer what we're actually tring to catch there.
jrjohnson
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the only thing that would cause an exception to get thrown in the constructor of the Ilios client class would be emitted out of the Moodle-core
get_config()method. which would only occur if we tried to read plugin config during system installation. we're not doing this here, so let's get rid of it.as a positive side-effect, this also eliminates the need to correct the incorrect position of the chained re-thrown exception that's being passed into the Exception constructor.
while at it, i moved the client instantiation out of the try/catch block in the new sync job form. should make it clearer what we're actually tring to catch there.