Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve trigger actions #227

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Improve trigger actions #227

merged 4 commits into from
Jul 13, 2023

Conversation

damianooldoni
Copy link
Member

This small PR:

  • avoids automatic checks actions will run on drafts
  • allows them to be run on demand

@damianooldoni
Copy link
Member Author

I noticed that actions are triggered when a set up @PietrH as reviewer. I will then remove that option. Only ready_for_review then. The syntax of [review_requested, ready_for_review] is an OR operator it seems.

@damianooldoni damianooldoni removed the request for review from PietrH July 13, 2023 08:47
@PietrH
Copy link
Member

PietrH commented Jul 13, 2023

Shouldn't CI run on draft pull requests?

@damianooldoni
Copy link
Member Author

damianooldoni commented Jul 13, 2023

A draft PR is still work in progress. I find annoying to have all those failures which are actually expected.

So, the idea behind this PR is:

  1. you create a draft of a PR to "claim" your are working on something, so that everybody knows and in case can collaborate. You can also point to such cork in progress in case needed (answering to some issues, etc.)
  2. you run automatic checks on demand on a draft whenever you want
  3. once the draft is ready for review, i.e. the PR is not a draft anymore, the checks run automatically at each commit
  4. you will be able to assign a reviewer afterwards once all checks pass. You can even assign a reviewer before of course, but, as you noted, it's not really "polite" 😄

Does it make sense?

@damianooldoni damianooldoni marked this pull request as ready for review July 13, 2023 09:11
@damianooldoni damianooldoni self-assigned this Jul 13, 2023
@damianooldoni damianooldoni merged commit 0c93005 into main Jul 13, 2023
10 checks passed
@damianooldoni damianooldoni deleted the improve-trigger-actions branch July 13, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants