Recherche ajout loupe #1183
Recherche ajout loupe #1183
Conversation
|
the glass (la loupe) is in true to show the behavoir on the button and the keydown. |
packages/common/src/lib/entity/entity-table/entity-table.component.ts
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/map/baselayers-switcher/mini-basemap.component.ts
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/search/search-bar/search-bar.component.html
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/search/search-bar/search-bar.component.html
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/search/search-bar/search-bar.component.html
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/search/search-bar/search-bar.component.html
Outdated
Show resolved
Hide resolved
PhilippeLafreniere18
added
ready to merge
in progress
PhilippeLafreniere18
added
ready to merge
and removed
in progress
|
@karengeo Ready for review? |
|
yes, Im sorry I didn,t see your message. It was ready two weeks ago. |
…ouverte/igo2-lib into recherche-ajout-loupe
|
I have simplified the method and for the search by coordinates I also insert a way to see the coordinate without problems. |
|
|
||
| //Function to reverse the value of the parameter | ||
| function reverseString(coordReInv) { | ||
| return coordReInv; |
There was a problem hiding this comment.
The function returns coordReInv which is what is provided to the function. Necessary?
There was a problem hiding this comment.
Yes, because the changes on design tool makes a slight change to the coordinate order. For this reason, when a search was performed, it was not executed. By reversing the coordinate values IGO can clearly understand that they are coordinates and focus them properly as desired.
| if(result){ | ||
| this.store.state.update(result,{focused:true,selected:true},true); | ||
| }else{ | ||
| reverseString(coordInv); |
There was a problem hiding this comment.
Necessary? See comment above
There was a problem hiding this comment.
Yes, because when a coordinate search is performed we will not have a list of options with score , the value will be exact. For this reason, I proposed it this way, if there is any way to improve it, ideas are welcome
|
Replaced by #1600 |
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
N/A
What is the new behavior?
add behavior when searching for characters and clicking on the magnifying glass to search for a first item on the map. The enter key has the same behavior
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
N/A
Other information: