Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recherche ajout loupe #1183
Recherche ajout loupe #1183
Changes from all commits
2339991
44ad966
44702ee
3dd2ade
b00339e
23b3bc9
7d9baf0
53c8e94
0c00e1d
ad3e96d
0b9a000
f71ae28
ba6aeb1
009ec78
0d3f91c
8d3cb3a
12f41b8
3c586cf
9a40db3
808e512
c74cd96
6e4634a
4bcbb51
81c5528
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function returns coordReInv which is what is provided to the function. Necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because the changes on design tool makes a slight change to the coordinate order. For this reason, when a search was performed, it was not executed. By reversing the coordinate values IGO can clearly understand that they are coordinates and focus them properly as desired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Necessary? See comment above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because when a coordinate search is performed we will not have a list of options with score , the value will be exact. For this reason, I proposed it this way, if there is any way to improve it, ideas are welcome