feat: add zaar #246

ALPAC-4 · 2025-01-14T05:36:58Z

Add Zaar
- add chain.json
- add assetlist.json
Add culinaris executor api
fix yominet asset list url

Summary by CodeRabbit

New Features
- Added executor URI for Culinaris testnet.
- Expanded IBC channel interoperability for Initia testnet with Zaar testnet.
- Introduced new Zaar testnet configuration and asset list.
Documentation
- Updated asset list URL for Yominet testnet.
- Restructured asset list file path for Yominet testnet.

coderabbitai · 2025-01-14T05:37:07Z

Walkthrough

This pull request introduces configuration updates for multiple testnets, including Culinaris, Initia, Yominet, and Zaar. The changes primarily involve adding new metadata fields, updating asset list URLs, and introducing a new testnet configuration for Zaar. The modifications focus on enhancing network configuration, interoperability, and asset representation across different testnets.

Changes

File	Change Summary
`testnets/culinaris/chain.json`	Added `executor_uri` in metadata with a specific API endpoint URL
`testnets/initia/chain.json`	Added two new IBC channels for "zaar-testnet-1" with transfer and NFT transfer ports
`testnets/yominet/chain.json`	Updated `assetlist` URL to use a nested directory structure
`testnets/zaar/assetlist.json`	New asset list file added for "Fake Zaar" ERC20 token
`testnets/zaar/chain.json`	New chain configuration file for Zaar testnet with comprehensive network details

Sequence Diagram

sequenceDiagram
    participant Initia as Initia Testnet
    participant Zaar as Zaar Testnet
    
    Initia->>Zaar: Establish IBC Channel (transfer)
    Initia->>Zaar: Establish IBC Channel (nft-transfer)
    
    Zaar-->>Initia: Confirm Channel Connections

Possibly related PRs

feat: culinaris #245: Changes to the Culinaris testnet's chain.json configuration, potentially laying groundwork for the executor_uri addition

Poem

🐰 Hoppity hop through the testnet maze,
Configurations dancing in digital ways,
IBC channels bridging with care,
New URIs and assets everywhere,
A rabbit's delight in network praise! 🌐

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f501362 and 3d2c65f.

📒 Files selected for processing (2)

testnets/zaar/assetlist.json (1 hunks)
testnets/zaar/chain.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

testnets/zaar/chain.json
testnets/zaar/assetlist.json

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Cloudflare Pages: registry-initiation-1

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

cloudflare-workers-and-pages · 2025-01-14T05:38:56Z

Deploying registry-initiation-1 with Cloudflare Pages

Latest commit:	`3d2c65f`
Status:	✅ Deploy successful!
Preview URL:	https://e5a23c0b.registry-initiation-1.pages.dev
Branch Preview URL:	https://feat-zaar.registry-initiation-1.pages.dev

View logs

cloudflare-workers-and-pages · 2025-01-14T05:39:14Z

Deploying registry-devnet with Cloudflare Pages

Latest commit:	`3d2c65f`
Status:	✅ Deploy successful!
Preview URL:	https://af5381e5.registry-devnet.pages.dev
Branch Preview URL:	https://feat-zaar.registry-devnet.pages.dev

View logs

cloudflare-workers-and-pages · 2025-01-14T05:39:15Z

Deploying registry-testnet with Cloudflare Pages

Latest commit:	`3d2c65f`
Status:	✅ Deploy successful!
Preview URL:	https://26ccf3ef.initia-registry-testnets.pages.dev
Branch Preview URL:	https://feat-zaar.initia-registry-testnets.pages.dev

View logs

coderabbitai

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ae5112a and f501362.

⛔ Files ignored due to path filters (2)

testnets/zaar/images/ZAAR.png is excluded by !**/*.png
testnets/zaar/images/ZAAR.svg is excluded by !**/*.svg

📒 Files selected for processing (5)

testnets/culinaris/chain.json (1 hunks)
testnets/initia/chain.json (1 hunks)
testnets/yominet/chain.json (1 hunks)
testnets/zaar/assetlist.json (1 hunks)
testnets/zaar/chain.json (1 hunks)

✅ Files skipped from review due to trivial changes (1)

testnets/yominet/chain.json

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Cloudflare Pages: registry-initiation-1

🔇 Additional comments (4)

testnets/zaar/assetlist.json (1)

24-33: Verify image assets existence.

The image URLs reference PNG and SVG files. Ensure these files exist in the repository.

✅ Verification successful

✓ Image assets verified

Both PNG and SVG image files exist at the specified paths in the repository.
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Check if the referenced image files exist
for img in "testnets/zaar/images/ZAAR.png" "testnets/zaar/images/ZAAR.svg"; do
  if [ ! -f "$img" ]; then
    echo "Missing image file: $img"
  fi
done
Length of output: 247
testnets/zaar/chain.json (1)

66-78: Verify IBC channel configuration consistency.

The IBC channels configuration matches with the channels added in initia/chain.json. This looks good.

testnets/culinaris/chain.json (1)

82-82: LGTM! Executor URI follows the consistent pattern.

The added executor_uri follows the same format as other testnets and matches the domain pattern used in other API endpoints.

testnets/initia/chain.json (1)

307-318: LGTM! IBC channels are properly configured.

The added IBC channels for Zaar testnet follow the consistent pattern:

Correct port IDs (transfer, nft-transfer)

Standard versions (ics20-1, ics721-1)

Channel IDs follow the sequential numbering

testnets/zaar/assetlist.json

testnets/zaar/chain.json

feat: add zaar

f7c8cd6

fix: move asset list and minitia to metadata

f501362

simcheolhwan approved these changes Jan 14, 2025

View reviewed changes

coderabbitai bot reviewed Jan 14, 2025

View reviewed changes

testnets/zaar/assetlist.json Outdated Show resolved Hide resolved

testnets/zaar/chain.json Outdated Show resolved Hide resolved

testnets/zaar/chain.json Outdated Show resolved Hide resolved

ALPAC-4 added 2 commits January 14, 2025 15:33

fix: fix zaar chain name and image urls

86f76a2

fix: fix zaar chain name and image urls

3d2c65f

simcheolhwan approved these changes Jan 14, 2025

View reviewed changes

ALPAC-4 merged commit d57bc8d into main Jan 14, 2025
11 checks passed

ALPAC-4 deleted the feat/zaar branch January 14, 2025 06:39

coderabbitai bot mentioned this pull request Jan 14, 2025

fix: fix zaar evm chain id #248

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add zaar #246

feat: add zaar #246

ALPAC-4 commented Jan 14, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 14, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

cloudflare-workers-and-pages bot commented Jan 14, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 14, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 14, 2025 •

edited

Loading

coderabbitai bot left a comment

feat: add zaar #246

feat: add zaar #246

Conversation

ALPAC-4 commented Jan 14, 2025 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Jan 14, 2025 • edited Loading

Walkthrough

Changes

Sequence Diagram

Possibly related PRs

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

cloudflare-workers-and-pages bot commented Jan 14, 2025 • edited Loading

Deploying registry-initiation-1 with Cloudflare Pages

cloudflare-workers-and-pages bot commented Jan 14, 2025 • edited Loading

Deploying registry-devnet with Cloudflare Pages

cloudflare-workers-and-pages bot commented Jan 14, 2025 • edited Loading

Deploying registry-testnet with Cloudflare Pages

coderabbitai bot left a comment

Choose a reason for hiding this comment

ALPAC-4 commented Jan 14, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 14, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

cloudflare-workers-and-pages bot commented Jan 14, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 14, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Jan 14, 2025 •

edited

Loading