Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 3 #55

Merged
merged 5 commits into from
Nov 24, 2021
Merged

Issue 3 #55

merged 5 commits into from
Nov 24, 2021

Conversation

ColinFay
Copy link
Collaborator

@ColinFay ColinFay commented Nov 18, 2021 •
edited
Loading

Close #3

@ColinFay ColinFay mentioned this pull request Nov 18, 2021
Closed
12 tasks
ColinFay and others added 2 commits November 18, 2021 15:51
@ColinFay
Forgot to push the NAMESPACE
f667107
@statnmap
Allow Non UTF-8 source
5248856 
- Add unit test to check_translation_csv()
- closes #61
@statnmap
Copy link
Collaborator

I added some unit tests and the possibility to parse a non UTF-8 csv file if created with Excel on Windows.
I let you check this and then you can accept the PR.

@ColinFay ColinFay merged commit fab9b32 into issue-47 Nov 24, 2021
@statnmap statnmap deleted the issue-3 branch April 21, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@statnmap statnmap Awaiting requested review from statnmap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ColinFay @statnmap