Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize status flow validation #1408

Merged

Conversation

BalaBalaYi
Copy link
Collaborator

What changes were proposed in this pull request?

Add a status flow validation.

Why are the changes needed?

To avoid corner case like 'running' -> 'pending' which will cause unexpected fault tolerance.

Does this PR introduce any user-facing change?

No

How was this patch tested?

UT

@BalaBalaYi BalaBalaYi added the bug Something isn't working label Dec 27, 2024
Copy link
Collaborator

@majieyue majieyue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@workingloong workingloong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@workingloong
Copy link
Collaborator

To avoid corner case like 'running' -> 'pending'
Does the pod status change from running to pending ?

@BalaBalaYi
Copy link
Collaborator Author

allowed_transitions

yes. under tkp case.

Copy link
Collaborator

@samplise samplise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BalaBalaYi BalaBalaYi merged commit 9e85899 into intelligent-machine-learning:master Dec 30, 2024
7 checks passed
liyzcj pushed a commit that referenced this pull request Jan 22, 2025
* optimize status flow validation

* lint

* lint

(cherry picked from commit 9e85899)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants