-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Iptools and GeoIP dependencies #2896
Comments
@mekarpeles are you able to confirm whether this method for getting loan stats is fully deprecated? openlibrary/openlibrary/plugins/books/readlinks.py Lines 114 to 141 in 457e6d6
I beleive the current used method which uses the latest API (not fake subjects) is here: openlibrary/openlibrary/core/ia.py Lines 123 to 127 in 836044c
|
closes #2878 We know a large portion of our Python modules are out of date, and that some of them are not even used for current functionality. Manual review and fixing of the versions that are causing active problems is required at this stage. Currently minor point version updates are more difficult and risky than they should be, if there is not an active reason to update a module, we shouldn't at this stage. Removing some out of date unused dependencies is preferable to keeping them current without understanding how we use them, e.g. #2896 When we remove what is not needed and get to a stable point with Python 3, we can re-enable this tool.
closes #2878 We know a large portion of our Python modules are out of date, and that some of them are not even used for current functionality. Manual review and fixing of the versions that are causing active problems is required at this stage. Currently minor point version updates are more difficult and risky than they should be, if there is not an active reason to update a module, we shouldn't at this stage. Removing some out of date unused dependencies is preferable to keeping them current without understanding how we use them, e.g. #2896 When we remove what is not needed and get to a stable point with Python 3, we can re-enable this tool.
#2944 should remove iptool rather than update it. |
If someone wants to help with removing these modules please feel free to begin. |
These dependencies appear to only be used by the deprecated
Libraries
class and endpoint.Rather than concern ourselves about modern version numbers and compatibility of modules we are not using, let's remove them and their references.
relates to #1694
should replace #2893
and #2866
Describe the problem that you'd like solved
Proposal & Constraints
Additional context
Stakeholders
The text was updated successfully, but these errors were encountered: