Switch to official GeoIP module #2893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfmorris
added
Theme: Upgrade to Python 3
State: Blocked
|
Closing in favor of the fix proposed in #2896 which will hopefully land soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1694
This updates to the most recent MaxMind GeoIP legacy API module which is Python 3 compatible and API compatible since it's a direct descendent of what we're using.
We switch from our private fork, which was apparently only to enable it to be uploaded to PyPI, to the official MaxMind version.
Technical
This changes a Python dependency which will need to be handled on the production servers.
Testing
Tests pass, but it should be tested with a live database on dev.
Stakeholders
@hornc @mekarpeles