Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[uss_qualifier] add a default margin when querying interactions from mock_uss #757

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −3
Draft

[uss_qualifier] add a default margin when querying interactions from mock_uss #757

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions ...cenarios/astm/utm/data_exchange_validation/test_steps/expected_interactions_test_steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@
)
from monitoring.uss_qualifier.scenarios.scenario import TestScenarioType

# Margin interaction lookup to prevent issues from slight clock skew
INTERACTION_LOG_CLOCK_SKEW_MARGIN = timedelta(seconds=1)


def expect_mock_uss_receives_op_intent_notification(
scenario: TestScenarioType,
Expand Down Expand Up @@ -94,20 +97,34 @@ def mock_uss_interactions(
since: StringBasedDateTime,
query_params: Optional[Dict[str, str]] = None,
is_applicable: Optional[Callable[[Interaction], bool]] = None,
include_clock_skew_buffer: bool = True,
) -> Tuple[List[Interaction], Query]:
"""Determine if mock_uss recorded an interaction for the specified operation in the specified direction."""
"""
Determine if mock_uss recorded an interaction for the specified operation in the specified direction.

if include_clock_skew_buffer is True (the default), interactions will be looked up slightly earlier than specified
(see the INTERACTION_LOG_CLOCK_SKEW_MARGIN constant) to prevent a small clock skew from breaking scenarios.
"""

lookup_time = (
since.datetime - INTERACTION_LOG_CLOCK_SKEW_MARGIN
if include_clock_skew_buffer
else since.datetime
)
margin_message = " (includes skew margin)" if include_clock_skew_buffer else ""
with scenario.check(
"Mock USS interactions logs retrievable", [mock_uss.participant_id]
) as check:
try:
interactions, query = mock_uss.get_interactions(since)
interactions, query = mock_uss.get_interactions(
StringBasedDateTime(lookup_time)
)
scenario.record_query(query)
except QueryError as e:
for q in e.queries:
scenario.record_query(q)
check.record_failed(
summary=f"Error from mock_uss when attempting to get interactions since {since}",
summary=f"Error from mock_uss when attempting to get interactions since {lookup_time }{margin_message}",
details=f"{str(e)}\n\nStack trace:\n{e.stacktrace}",
query_timestamps=[q.request.timestamp for q in e.queries],
)
Expand Down
Loading