Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#600] Update faq.yml #771

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

[#600] Update faq.yml #771

wants to merge 21 commits into from

Conversation

mzzntn
Copy link

@mzzntn mzzntn commented Oct 11, 2020

Added English translation #600

Checklist

  • I followed the indications in the CONTRIBUTING
  • The documentation related to the proposed change has been updated accordingly (also comments in code).
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Ready for review! 🚀

Fixes

Added English translation italia#600
Copy link
Member

@libremente libremente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mzzntn and thanks for the great work! Just few comments here, let me know if you need support. Thanks a lot!

_data/faq.yml Outdated Show resolved Hide resolved
_data/faq.yml Outdated Show resolved Hide resolved
_data/faq.yml Outdated Show resolved Hide resolved
_data/faq.yml Outdated Show resolved Hide resolved
_data/faq.yml Outdated Show resolved Hide resolved
_data/faq.yml Outdated Show resolved Hide resolved
_data/faq.yml Outdated Show resolved Hide resolved
@libremente
Copy link
Member

Also @mzzntn would it be possible to use a maximum of 80 cols when formatting the file? That would make the file look cleaner. Thanks!

mzzntn and others added 8 commits October 13, 2020 22:56
Co-authored-by: libremente <[email protected]>
Co-authored-by: libremente <[email protected]>
Co-authored-by: libremente <[email protected]>
Co-authored-by: libremente <[email protected]>
Co-authored-by: libremente <[email protected]>
Co-authored-by: libremente <[email protected]>
Co-authored-by: libremente <[email protected]>
@mzzntn
Copy link
Author

mzzntn commented Oct 13, 2020

Hi @libremente

Thanks for your comments, sorry I didn't know about the different links for the english version otherwise I'd have used those :). Btw I've updated the PR with your comments + the maximum 80 cols specification, I'm not super confident with github, so I hope that everything works as expected.

_data/faq.yml Outdated Show resolved Hide resolved
_data/faq.yml Outdated Show resolved Hide resolved
_data/faq.yml Outdated Show resolved Hide resolved
Copy link
Member

@libremente libremente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mzzntn please review the English translations as mentioned below.

_data/faq.yml Outdated Show resolved Hide resolved
_data/faq.yml Outdated Show resolved Hide resolved
_data/faq.yml Outdated Show resolved Hide resolved
_data/faq.yml Show resolved Hide resolved
_data/faq.yml Outdated Show resolved Hide resolved
_data/faq.yml Outdated Show resolved Hide resolved
_data/faq.yml Outdated Show resolved Hide resolved
_data/faq.yml Outdated Show resolved Hide resolved
href="https://docs.italia.it/italia/developers-italia/gl-acquisition-and-reuse-software-for-pa-docs/en/stabile/software-reuse/open-licences-and-selecting-a-licence.html#choosing-a-licence">this
resource</a>.
item6:
question: Is it possible in the process of Reuse of a solution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This translation does not make a lot of sense. Please review it.

_data/faq.yml Outdated Show resolved Hide resolved
_data/faq.yml Outdated Show resolved Hide resolved
_data/faq.yml Outdated Show resolved Hide resolved
_data/faq.yml Outdated Show resolved Hide resolved
_data/faq.yml Outdated Show resolved Hide resolved
@sebbalex sebbalex requested a review from bfabio January 21, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate FAQ in English
2 participants