Fix: Feature server REFER #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davehorton
force-pushed
the
fix/feature-refer
branch
from
a12b114
to
1addc2c
Compare
davehorton
force-pushed
the
fix/feature-refer
branch
from
1addc2c
to
4f9fb6a
Compare
two56
force-pushed
the
fix/feature-refer
branch
from
4f9fb6a
to
2a2c3ae
Compare
two56
force-pushed
the
fix/feature-refer
branch
from
2a2c3ae
to
63b47a2
Compare
davehorton
approved these changes
Aug 20, 2023
|
|
||
| const uac = await this.srf.createUAC(referTo.uri, {localSdp: dlg.local.sdp, headers}); | ||
| this.uas = uac; | ||
| uac.type = 'uas'; |
There was a problem hiding this comment.
interesting, 'createUAC' does not do this?
There was a problem hiding this comment.
Are you referring to setting type?
We start with this scenario:
FS1 -> UAS (SBC) UAC -> End point
When the refer takes place we end up with:
FS2 <- UAC (SBC) UAC -> End point
Quite a few tests in the call-session check (uac|uas).type to handle things like INFO frames correctly, in my case startCallRecording. As the leg to FS2 is now a UAC we need to "correct" it so things are handled in the right way.
Hopefully that shouldn't cause a problem?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #89
This is mostly correcting (I think) the old code. Adding the destruction of the old dialog of the REFERing feature server and returning a 488 if things go wrong.
I've tested the best I can, I'm getting audio!
I hope re-using the
to-tagandfrom-tagis the right thing to do when setting up the dialog/audio to the target feature server?