-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize RequestHandlerWrapperImpl object construction in Mediator's Send Methods #966
Conversation
…pressions for constructing RequestHandlerWrapperImpl objects
… CreateStream<TResponse> also
…uest and Send for object request
^^ "Whoops" 🤣 |
This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
@jbogard Are you planning to merge this pull request? |
This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
Is this any faster than |
Hello @jbogard . No, activator is a still faster than non-cached compiled expressions. To cache the compiled expression, the request type must be known at compile time which in the current situation cannot happen. The only thing that is faster than cached activator is the non-cached direct construction with new. I will revert the changes and commit only the construction with new. |
This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This PR was closed because it has been stalled for 14 days with no activity. |
Remove activator usage from Send methods, and use new and compiled expression for constructing RequestHandlerWrapperImpl objects