Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize RequestHandlerWrapperImpl object construction in Mediator's Send Methods #966

Closed
wants to merge 9 commits into from
Closed

Optimize RequestHandlerWrapperImpl object construction in Mediator's Send Methods #966

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b7b9d28
remove activator usage from Send methods, and use new and compiled ex…
pauldin91 Oct 22, 2023
73adb45
remove try catch
pauldin91 Oct 22, 2023
183c6ce
Apply construction with lambda expressions in PublishNotification and…
pauldin91 Nov 2, 2023
9279156
Replace activator completely from methods CreateStream for object req…
pauldin91 Nov 2, 2023
066cae9
Revert "Replace activator completely from methods CreateStream for ob…
pauldin91 Jan 9, 2024
a56ca63
Revert "remove try catch"
pauldin91 Jan 9, 2024
008fe8e
Revert "Apply construction with lambda expressions in PublishNotifica…
pauldin91 Jan 9, 2024
fa07b79
Revert "remove activator usage from Send methods, and use new and com…
pauldin91 Jan 9, 2024
d713d47
Revert changes and keep new construction in Mediator.Send<TRequest>
pauldin91 Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/MediatR/Mediator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,16 +64,14 @@ public Task Send<TRequest>(TRequest request, CancellationToken cancellationToken
throw new ArgumentNullException(nameof(request));
}

var handler = (RequestHandlerWrapper)_requestHandlers.GetOrAdd(request.GetType(), static requestType =>
var handler = (RequestHandlerWrapper) _requestHandlers.GetOrAdd(request.GetType(), static requestType =>
{
var wrapperType = typeof(RequestHandlerWrapperImpl<>).MakeGenericType(requestType);
var wrapper = Activator.CreateInstance(wrapperType) ?? throw new InvalidOperationException($"Could not create wrapper type for {requestType}");
return (RequestHandlerBase)wrapper;
return new RequestHandlerWrapperImpl<TRequest>() ?? throw new InvalidOperationException($"Could not create wrapper type for {typeof(TRequest)}");
});

return handler.Handle(request, _serviceProvider, cancellationToken);
}

public Task<object?> Send(object request, CancellationToken cancellationToken = default)
{
if (request == null)
Expand Down