Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SubTask.getOwnerExecutable #2388

Merged
merged 8 commits into from
Jul 31, 2023
Merged

Use SubTask.getOwnerExecutable #2388

merged 8 commits into from
Jul 31, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented Jan 24, 2023

@jglick jglick mentioned this pull request Jan 24, 2023
Merged
6 tasks
@jglick jglick marked this pull request as ready for review April 7, 2023 17:55
@jglick jglick requested a review from a team as a code owner April 7, 2023 17:55
@olamy
Copy link
Member

olamy commented Apr 8, 2023

the build is failing because of RequireUpperBoundDeps rule failures.

jglick
jglick commented Jul 28, 2023
View reviewed changes
Copy link
Member Author

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@car-roll FYI

pom.xml
<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest</artifactId>
<version>${hamcrest.version}</version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #2444

@jglick
Copy link
Member Author

jglick commented Jul 28, 2023

Checked locally with

mvnd clean install dependency:sources -Dtest=InjectedTest -DfailIfNoTests=false

so I hope this can finally go green before it gets more merge conflicts!

@olamy olamy merged commit e40f92f into jenkinsci:master Jul 31, 2023
11 checks passed
@jglick jglick deleted the getOwnerExecutable branch July 31, 2023 20:27
@olamy
Copy link
Member

olamy commented Aug 1, 2023

I merged it but since this commit ATH test fail in timeout.

@jglick
Copy link
Member Author

jglick commented Aug 1, 2023

Perhaps from the Jenkins core or BOM updates? https://ci.blueocean.io/job/blueocean/job/master/2181/execution/node/65/log/ shows lots of stuff indicating mistakes in test setup

WARNING: encountered /home/jenkins/workspace/blueocean_master/acceptance-tests/runner/runtime/target/jenkins1717351725658294775home/plugins/credentials.hpi under a nonstandard name; expected credentials.jpi
SEVERE: Failed Loading plugin Credentials Plugin v1254.vb_96f366e7b_a_d (credentials)

Anyway should you not turn off ci.blueocean.io by now? https://ci.blueocean.io/job/blueocean/job/master/ has not been stable since November.

@olamy
Copy link
Member

olamy commented Aug 2, 2023

Perhaps from the Jenkins core or BOM updates? https://ci.blueocean.io/job/blueocean/job/master/2181/execution/node/65/log/ shows lots of stuff indicating mistakes in test setup

WARNING: encountered /home/jenkins/workspace/blueocean_master/acceptance-tests/runner/runtime/target/jenkins1717351725658294775home/plugins/credentials.hpi under a nonstandard name; expected credentials.jpi
SEVERE: Failed Loading plugin Credentials Plugin v1254.vb_96f366e7b_a_d (credentials)

Anyway should you not turn off ci.blueocean.io by now? https://ci.blueocean.io/job/blueocean/job/master/ has not been stable since November.

yup there is an issue here jenkins-infra/helpdesk#2954
I definitely agree it's not perfect (but not enough time to fix those) previously, the build was only unstable (e.g, known flaky ATH tests but now it hangs which ring some alarms to me)

@jglick jglick mentioned this pull request Aug 3, 2023
Merged
7 tasks
olamy pushed a commit to olamy/blueocean-plugin that referenced this pull request Aug 7, 2023
@jglick @olamy
Use SubTask.getOwnerExecutable (jenkinsci#2388)
fae831b 
* Use `SubTask.getOwnerExecutable`

* Update to releases

* Removing some gratuitous version overrides

* Using newest available BOM

* Restoring `InjectedTest`, deleting Animal Sniffer config obsolete as of jenkinsci#2379, and fixing `github` dep versions

* May as well go to 2.401.x now
basil
basil reviewed Aug 19, 2023
View reviewed changes
pom.xml
@@ -32,12 +32,11 @@
when changing jenkins core version please remember to change it in Jenkinsfile as well jenkinsVersions
and acceptance-tests/runner/scripts/args.sh
-->
<jenkins.version>2.361.4</jenkins.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implies a corresponding change in jenkinsci/bom/bom-2.387.x/pom.xml: jenkinsci/bom#2395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil left review comments

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jglick @olamy @basil