Introduce SubTask.getOwnerExecutable
#7599
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5733 introduced a way to go from
PlaceholderExecutable
toWorkflowRun
using supported APIs. For example: a Pipeline jobis running the
sh
step, and given thenode
block executor slot you want to look up the build which encompasses that (and perhaps othernode
blocks). However, ifsome-label
were currently unavailable and this item was sitting in the queue waiting to be scheduled, there would be noPlaceholderExecutable
yet, only aPlaceholderTask
, and there was no supported way to find the correspondingWorkflowRun
. Various plugins therefore added a dependency onworkflow-durable-task-step
and directly cast toPlaceholderTask
to call itsrun
orrunForDisplay
methods; for example I could find jenkinsci/blueocean-plugin#2388 as well as jenkinsci/throttle-concurrent-builds-plugin#197 (though for now this still needs aworkflow-durable-task-step
dep due to another call) as well as a number more in less common plugins. This new API allows the navigation to the owning build to be done in a proper way, assuming jenkinsci/workflow-durable-task-step-plugin#287.Testing done
N/A
Proposed changelog entries
SubTask.getOwnerExecutable
to be implemented in Pipeline.Maintainer checklist
Before the changes are marked as
ready-for-merge
:upgrade-guide-needed
label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidate
to be considered (see query).