-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Updates for Kubernetes v1.32.0 #3302
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @gman0. Thanks for your PR. I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
Ran: make codegen On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
9fbd890
to
41067a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks quite clean
It's in a draft state, we are not gonna merge :) but removing prefixes allows CI to run with a cleaner signal |
/test all |
garbagecollector.Run now requires an intial timeout argument. On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
… feature gate See kubernetes/kubernetes#127058 On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
The following error comes up in pull-kcp-build-image, pull-kcp-verify, pull-kcp-verify-codegen, pull-kcp-test-e2e and pull-kcp-test-e2e-multiple-runs:
But https://proxy.golang.org/github.com/kcp-dev/kubernetes/staging/src/k8s.io/component-helpers/@v/v0.0.0-20250212172239-c6ebc5941362.mod looks ok. Will re-run. |
/test pull-kcp-build-image |
@gman0: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
41067a0
to
1113f20
Compare
/test pull-kcp-lint |
On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
The feature gate is now stable and removed. See kubernetes/kubernetes#126645 On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
…mplete k8s.io/kubernetes/pkg/controplane/apiserver/options.Complete() has a different signature that includes a ctx and cmd flags, and so we need to wire these to its callers. On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
…ount-signing-endpoint On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
coordination.k8s.io/v1alpha2 replaced v1alpha1, see k/k#127857. On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
…uginsInKube list On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
…rmers MutatingAdmissionPolicy is in admissionregistration.k8s.io/v1alpha1 and disabled by default in Kubernetes v1.32. However, we're overriding admissionregistration.k8s.io/v1alpha1 to be enabled until next release, which means MAP is also served and we need to create informers for it. On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
…PIExport builtin types MutatingAdmissionPolicy is in admissionregistration.k8s.io/v1alpha1 and disabled by default in Kubernetes v1.32. However, we're overriding admissionregistration.k8s.io/v1alpha1 to be enabled until next release, which means MAP is also served and we need to expose it. On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
Kubernetes v1.32 implicitly removes ValidatingAdmissionPolicy and ValidatingAdmissionPolicyBinding from admissionregistration.k8s.io/v1alpha in accordance with APILifecycle policy. This commit removes the relevant CRDs, informers and APIExport builtin types. On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
…on.k8s.io/v1alpha1 override On-behalf-of: SAP [email protected] Signed-off-by: Robert Vasek <[email protected]>
1113f20
to
6d4ca80
Compare
@gman0: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
// dependencies version we're currently using. | ||
var defaultVersionedGenericControlPlaneFeatureGates = map[featuregate.Feature]featuregate.VersionedSpecs{ | ||
WorkspaceMounts: { | ||
{Version: version.MustParse("1.28"), Default: false, PreRelease: featuregate.Alpha}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this mean? Why do we have our own features here and why with 1.28?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have our own features here
To make them available with the rest of the features that are otherwise k8s-specific. I'm assuming this is how it was before too :D
why with 1.28
"k8s.io/apiserver/pkg/util/feature".DefaultMutableFeatureGate
that we merge defaultVersionedGenericControlPlaneFeatureGates
into (inside the init
function) is versioned, and so we need some version.
kcp has its own versioning, k8s has its own, and this creates a bit of a problem that I indeed wasn't sure how to solve cleanly.
At the moment there seems to be only one way to determine if a specific feature is enabled or disabled by default, and that's through comparing that feature's VersionedSpec with the "emulation" version (see our featureSpecAtEmulationVersion
function, and the same one in upstream). "k8s.io/apiserver/pkg/util/feature".DefaultMutableFeatureGate
sets the emulation version to be DefaultKubeBinaryVersion = "1.32"
in the feature gate's constructor.
To keep all features available, regardless whether they are coming from k8s or kcp, I decided to stick with k8s's versioning, and picked 1.28
specifically because that was the k8s version kcp was depending on when WorkspaceMounts
was introduced. I can improve the comment to make this a bit clearer.
One thing to note is that using k8s versioning for kcp features means we cannot release a new feature without bumping k8s (minor!) version too :/ this doesn't sound correct and is something we should definitely discuss.
Lgtm. |
Summary
This PR updates dependencies to be in line with k8s v1.32.0.
Related issue(s)
Fixes #3209
Release Notes