fix: improve convertion errors and handle invalid ABI #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
shamsasari
reviewed
Sep 27, 2024
shamsasari
reviewed
Sep 27, 2024
shamsasari
reviewed
Sep 27, 2024
HermanObst
reviewed
Sep 27, 2024
notlesh
reviewed
Oct 1, 2024
notlesh
approved these changes
Oct 1, 2024
|
@whichqua please address @shamsasari comments before merging |
* fix: handle contract commitments for contract without data items Problem: reexecution panics when a contract doesnt have data items Solution: handle the edge case to prevent panics * fix: only one commitment return
HermanObst
requested changes
Oct 2, 2024
matzayonc
pushed a commit
to matzayonc/snos
that referenced
this pull request
Oct 15, 2024
…strange#387) * fix: improve convertion errors to provide more context * fix: better error handling and fix for invalid abi * fix: add tests for blocks, and minor fixes based on review * fix: handle contract commitments for contract without data items (keep-starknet-strange#388) * fix: handle contract commitments for contract without data items Problem: reexecution panics when a contract doesnt have data items Solution: handle the edge case to prevent panics * fix: only one commitment return * Revert "fix: handle contract commitments for contract without data items (keep-starknet-strange#388)" (keep-starknet-strange#394) This reverts commit 0c13f1c. --------- Co-authored-by: Herman Obst Demaestri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: During convertions between types from blockifier, starknet and cairolang classes, the errors returned are not consistent. This also led to finding an invalid api bug during convertion.
Solution:
ConvertionErrorandRpcClientErrorand handle them appropriately.Nonewhen abi is not valid JSON.Issue Number: N/A
Type
Description
Breaking changes?