Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version 2, 3 and 4 of ECalBarrel_NobelLiquid_InclinedTrapezoid_o1_v0*_geo.cpp by including layered calorimeter data #361

Merged
merged 7 commits into from
Nov 14, 2024
Merged

Update version 2, 3 and 4 of ECalBarrel_NobelLiquid_InclinedTrapezoid_o1_v0*_geo.cpp by including layered calorimeter data #361

merged 7 commits into from
Nov 14, 2024

Conversation

SwathiSasikumar
Copy link
Contributor

BEGINRELEASENOTES

  • This updates version ECalBarrel_NobelLiquid_InclinedTrapezoid_o1_v02_geo.cpp and ECalBarrel_NobelLiquid_InclinedTrapezoid_o1_v03_geo.cpp with layered calorimeter data for PandoraPFA as given in ECalBarrel_NobelLiquid_InclinedTrapezoid_o1_v01_geo.cpp
  • Update on the compact file LAr_ECalBarrel.xml based on the latest parameters and names...

ENDRELEASENOTES

BrieucF
BrieucF reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@BrieucF BrieucF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also looks like we have no test for CLD_o4_v05, it could be useful to add one

FCCee/CLD/compact/CLD_o4_v05/LAr_ECalBarrel.xml Outdated Show resolved Hide resolved
@BrieucF
Copy link
Contributor

BrieucF commented Sep 20, 2024

Shall we revive this PR @SwathiSasikumar ?

@SwathiSasikumar SwathiSasikumar mentioned this pull request Nov 13, 2024
Closed
@BrieucF
Copy link
Contributor

BrieucF commented Nov 14, 2024

Hi @SwathiSasikumar , @andresailer , the tests are failing

@BrieucF BrieucF changed the title Update version 2 and version 3 of LAr ECal (ECalBarrel_NobelLiquid_InclinedTrapezoid_o1_v01_geo.cpp) by including layered calorimeter data. Update version 2, 3 and 4 of ECalBarrel_NobelLiquid_InclinedTrapezoid_o1_v0*_geo.cpp by including layered calorimeter data Nov 14, 2024
@SwathiSasikumar
Copy link
Contributor Author

SwathiSasikumar commented Nov 14, 2024 •
edited
Loading

Hi @SwathiSasikumar , @andresailer , the tests are failing

Things look fine now. I have fixed the issues. The tests concerning the updated files are successful.

@andresailer andresailer merged commit 1d2721d into key4hep:main Nov 14, 2024
5 of 6 checks passed
@BrieucF BrieucF mentioned this pull request Nov 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrieucF BrieucF BrieucF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SwathiSasikumar @BrieucF @andresailer