Update SystemClock.kt #208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is updated to always send timesampt in English since api fails if user's device langauge is arabic and arabic timestamp is sent
evan-masseau
approved these changes
Jan 24, 2025
|
Going to try and get a unit test in for this today. Thanks for opening this! |
5 tasks
|
I didn't have push permissions in your fork so I made a new PR with a unit test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the SDK to ensure that timestamps are always sent in English, regardless of the user's device language settings. This resolves an issue where the API fails if an Arabic timestamp is sent due to the user's device being set to Arabic.
Description
Updated the SDK to ensure that timestamps are always sent in English, regardless of the user's device language settings. This resolves an issue where the API fails if an Arabic timestamp is sent due to the user's device being set to Arabic.
Check List
Are you changing anything with the public API?
No, this change is internal and does not affect the public API.
Are your changes backwards compatible with previous SDK Versions?
Yes, the change maintains compatibility with previous SDK versions.
Have you tested this change on a real device?
Yes, the changes have been tested on a real device to ensure proper functionality.
Have you added unit test coverage for your changes?
Unit tests have been added to verify that the timestamp is always sent in English.
Have you verified that your changes are compatible with all Android versions the SDK currently supports?
Yes, the changes have been verified to work across all supported Android versions.
Changelog / Code Overview
Modified: The SystemClock implementation now explicitly uses Locale.ENGLISH in the SimpleDateFormat instance to ensure timestamps are consistently formatted in English.
Reason: The API fails when Arabic-formatted timestamps are sent, as the system defaults to the device's language settings. This update ensures consistent API behavior regardless of the user's locale.
Supporting Material:
Test Plan
Tested the updated SystemClock implementation by simulating device language settings in Arabic and verifying that the timestamp is sent in English.
Verified that the API accepts the updated timestamp format without errors.
Confirmed the change works across different Android versions and devices.
Related Issues/Tickets