Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SystemClock.kt with Unit Test and English Locale #210

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

dan-peluso
Copy link
Contributor

Description

Adding a unit test to @Musharaf13 s work.

#208

original PR

Check List

  • Are you changing anything with the public API?
  • Are your changes backwards compatible with previous SDK Versions?
  • Have you tested this change on real device?
  • Have you added unit test coverage for your changes?
  • Have you verified that your changes are compatible with all Android versions the SDK currently supports?

Changelog / Code Overview

Test Plan

added a unit test

Related Issues/Tickets

@dan-peluso dan-peluso requested a review from a team as a code owner January 24, 2025 16:39
@dan-peluso dan-peluso mentioned this pull request Jan 24, 2025
Copy link
Contributor

@evan-masseau evan-masseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the test

@Musharaf13
Copy link
Contributor

@jordan-griffin can you please review the pr?

@Musharaf13
Copy link
Contributor

@jordan-griffin @dan-peluso @evan-masseau Thank you guys for approving the fix. I would like to inquire when is the merging and release estimated to take place?
We are actually facing a ~2k API fails on daily basis for the last 7 days.

@dan-peluso dan-peluso force-pushed the dan/adding-ar-unit-test branch from 96ff2ea to c230bed Compare January 27, 2025 16:45
@evan-masseau evan-masseau merged commit 3fb0d31 into master Jan 27, 2025
6 checks passed
@evan-masseau evan-masseau deleted the dan/adding-ar-unit-test branch January 27, 2025 16:53
@evan-masseau
Copy link
Contributor

@Musharaf13 thanks again for your help, version 3.0.3 has just been released with your patch.

@Musharaf13
Copy link
Contributor

Musharaf13 commented Jan 27, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants