-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use new encryption flags from https://github.com/knative/networking/pull/858 #14379
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: KauzClay The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14379 +/- ##
==========================================
+ Coverage 86.08% 86.12% +0.04%
==========================================
Files 196 196
Lines 14880 14880
==========================================
+ Hits 12810 12816 +6
+ Misses 1759 1756 -3
+ Partials 311 308 -3
☔ View full report in Codecov by Sentry. |
Could you update the test script ? Line 388 in 7222bf9
|
6f465fb
to
8c5ec31
Compare
ba54857
to
e284288
Compare
e284288
to
5b03f86
Compare
5b03f86
to
e97337c
Compare
@KauzClay knative/networking#858 is merged 🎉 Would you mind updating here? |
33e01ca
to
34f8e07
Compare
319cabe
to
9e16097
Compare
3589d74
to
f5ed52f
Compare
@ReToCode how do you wanna do this one for Kourier? Just merge here first, and then address the rest with your PR here: knative-extensions/net-kourier#1116 ? |
Thanks, looks good. Let's do the kourier thing first. I updated the PR. |
/retest |
We need #14469 in first. |
See #14469 (comment) |
This was included in #14472. /close |
@ReToCode: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In response to knative/networking#858
Proposed Changes
Release Note