Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new encryption flags from https://github.com/knative/networking/pull/858 #14379

Closed
wants to merge 4 commits into from

Conversation

KauzClay
Copy link
Contributor

In response to knative/networking#858

Proposed Changes

  • Use new KnativeInternalTLS key when appropriate
  • Remove usage of Dataplane Trust

Release Note


@knative-prow
Copy link

knative-prow bot commented Sep 14, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/API API objects and controllers area/autoscale size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Sep 14, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: KauzClay
Once this PR has been reviewed and has the lgtm label, please assign skonto for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KauzClay KauzClay marked this pull request as ready for review September 14, 2023 15:54
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2023
@KauzClay KauzClay marked this pull request as draft September 14, 2023 15:55
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2023
@KauzClay
Copy link
Contributor Author

/retest

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4c3aaee) 86.08% compared to head (c37361e) 86.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14379      +/-   ##
==========================================
+ Coverage   86.08%   86.12%   +0.04%     
==========================================
  Files         196      196              
  Lines       14880    14880              
==========================================
+ Hits        12810    12816       +6     
+ Misses       1759     1756       -3     
+ Partials      311      308       -3     
Files Coverage Δ
pkg/reconciler/autoscaling/kpa/kpa.go 95.26% <100.00%> (ø)
pkg/reconciler/route/resources/ingress.go 94.80% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nak3
Copy link
Contributor

nak3 commented Sep 19, 2023

Could you update the test script ?

toggle_feature dataplane-trust minimal config-network

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2023
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 22, 2023
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2023
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 22, 2023
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2023
@ReToCode
Copy link
Member

ReToCode commented Oct 2, 2023

@KauzClay knative/networking#858 is merged 🎉 Would you mind updating here?

@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 2, 2023
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 2, 2023
@KauzClay KauzClay marked this pull request as ready for review October 2, 2023 14:54
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2023
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 2, 2023
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 2, 2023
@KauzClay
Copy link
Contributor Author

KauzClay commented Oct 2, 2023

@ReToCode how do you wanna do this one for Kourier? Just merge here first, and then address the rest with your PR here: knative-extensions/net-kourier#1116 ?

@ReToCode
Copy link
Member

ReToCode commented Oct 3, 2023

Thanks, looks good. Let's do the kourier thing first. I updated the PR.

@ReToCode
Copy link
Member

ReToCode commented Oct 3, 2023

/retest

@ReToCode
Copy link
Member

ReToCode commented Oct 3, 2023

We need #14469 in first.

@ReToCode
Copy link
Member

ReToCode commented Oct 3, 2023

See #14469 (comment)

@ReToCode
Copy link
Member

ReToCode commented Oct 5, 2023

This was included in #14472.

/close

@knative-prow knative-prow bot closed this Oct 5, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 5, 2023

@ReToCode: Closed this PR.

In response to this:

This was included in #14472.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 5, 2023
@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API API objects and controllers area/autoscale area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants