Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update net-kourier nightly #14469

Conversation

knative-automation
Copy link
Contributor

/assign @knative/serving-writers
/cc @knative/serving-writers

Produced via:

for x in kourier.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-kourier/latest/$x > ${GITHUB_WORKSPACE}/./third_party/kourier-latest/$x
done

Details:

bumping knative.dev/net-kourier 644b5c8...a895a08:
  > a895a08 Use aligned flags and secrets for `system-internal-tls` (# 1116)
  > 3fdb548 upgrade to latest dependencies (# 1127)

bumping knative.dev/net-kourier 644b5c8...a895a08:
  > a895a08 Use aligned flags and secrets for `system-internal-tls` (# 1116)
  > 3fdb548 upgrade to latest dependencies (# 1127)

Signed-off-by: Knative Automation <[email protected]>
@knative-prow knative-prow bot requested a review from a team October 3, 2023 11:05
@knative-prow knative-prow bot added area/networking size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4c3aaee) 86.08% compared to head (3280bda) 86.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14469   +/-   ##
=======================================
  Coverage   86.08%   86.08%           
=======================================
  Files         196      196           
  Lines       14880    14880           
=======================================
  Hits        12810    12810           
  Misses       1759     1759           
  Partials      311      311           

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor

skonto commented Oct 3, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2023
@skonto
Copy link
Contributor

skonto commented Oct 3, 2023

/approve

@knative-prow
Copy link

knative-prow bot commented Oct 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-automation, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2023
@ReToCode
Copy link
Member

ReToCode commented Oct 3, 2023

Seems like this does not work standalone and needs a combination of this PR, #14379 and #14399 and #14467

Trying to do this in: #14472

@ReToCode ReToCode closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants