resolve bug with KokkosComm::irecv, add to unit testing #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwpearson
previously approved these changes
Jun 18, 2024
janciesko
previously approved these changes
Jun 18, 2024
|
|
devreal
reviewed
Jun 18, 2024
| @@ -54,7 +54,7 @@ void test_1d(const View1D &a) { | |||
| } else if (1 == rank) { | |||
| int src = 0; | |||
| MPI_Request req; | |||
| KokkosComm::Impl::irecv(a, src, 0, MPI_COMM_WORLD, req); | |||
| KokkosComm::irecv(a, src, 0, MPI_COMM_WORLD, req); | |||
There was a problem hiding this comment.
There is still a difference between isend and irecv: isend returns a request, irecv has an output parameter. Is that on purpose?
There was a problem hiding this comment.
@cwpearson I just saw this, what is your opinion?
There was a problem hiding this comment.
We should probably have Irecv produce an output as well. I will accept this for now and open an issue against myself to implement it.
cwpearson
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, irecv was implemented in the KokkosComm namespace erroneously. This bug was not captured via unit testing because unit testing directly called Impl::irecv.