Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add availability probe for image controller #101

Merged
merged 8 commits into from
Apr 11, 2024

Conversation

mshaposhnik
Copy link
Contributor

@mshaposhnik mshaposhnik commented Apr 3, 2024

What does this PR do?

Checks Quay cnnectivity and credendials validity,
reports as a redhat_appstudio_imagecontroller_global_quay_app_available metric.

What issues does this PR fix or reference?

https://issues.redhat.com/browse/STONEBLD-1931

How to check:

Deploy to Openshift or K8S, check the redhat_appstudio_imagecontroller_global_quay_app_available metric value shoud be 1:

kubectl exec $(kubectl get pods -n image-controller -l control-plane=controller-manager --no-headers -o custom-columns=":metadata.name" ) -c manager -n image-controller  --  curl -s  http://localhost:8080/metrics | grep redhat_appstudio_imagecontroller_global_quay_app_available

image

Copy link

openshift-ci bot commented Apr 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: Max Shaposhnyk <[email protected]>
Signed-off-by: Max Shaposhnyk <[email protected]>
Signed-off-by: Max Shaposhnyk <[email protected]>
@mshaposhnik mshaposhnik marked this pull request as ready for review April 8, 2024 07:09
@openshift-ci openshift-ci bot requested review from mmorhun and psturc April 8, 2024 07:09
@mshaposhnik
Copy link
Contributor Author

/retest

Copy link
Contributor

@tkdchen tkdchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/metrics/quay.go Outdated Show resolved Hide resolved
Signed-off-by: Max Shaposhnyk <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Apr 10, 2024
Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mshaposhnik
Copy link
Contributor Author

/retest

@mshaposhnik
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented Apr 11, 2024

@mshaposhnik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/image-controller-e2e 8375566 link true /test image-controller-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mmorhun mmorhun merged commit 9b7f58a into konflux-ci:main Apr 11, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants