-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image controller update to dev & stg #3624
Image controller update to dev & stg #3624
Conversation
Signed-off-by: Max Shaposhnyk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mmorhun, mshaposhnik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
@@ -2,12 +2,12 @@ apiVersion: kustomize.config.k8s.io/v1beta1 | |||
kind: Kustomization | |||
resources: | |||
- ../base | |||
- https://github.com/redhat-appstudio/image-controller/config/default?ref=e5a29db5772c85b84d3246597e5b39f229d2925a | |||
- https://github.com/redhat-appstudio/image-controller/config/default?ref=0f0b61cef9f667bb8a93d79fc03554fff9bb335b | |||
|
|||
images: | |||
- name: quay.io/redhat-appstudio/image-controller | |||
newName: quay.io/redhat-appstudio/image-controller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mshaposhnik the image ref probably needs to be updated according to this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to use released image on dev & stage, so it shouldn't be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok so I guess release is probably not working well? since CI is failing due to quay.io/redhat-appstudio/image-controller not containing the required SHA
Signed-off-by: Max Shaposhnyk <[email protected]>
New changes are detected. LGTM label has been removed. |
/retest |
1 similar comment
/retest |
Included PRs: