Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image controller update to dev & stg #3624

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

@mshaposhnik mshaposhnik removed the request for review from gazarenkov April 24, 2024 08:21
Copy link
Member

@mmorhun mmorhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Apr 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmorhun, mshaposhnik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mshaposhnik
Copy link
Contributor Author

/retest

4 similar comments
@mshaposhnik
Copy link
Contributor Author

/retest

@mshaposhnik
Copy link
Contributor Author

/retest

@mshaposhnik
Copy link
Contributor Author

/retest

@mshaposhnik
Copy link
Contributor Author

/retest

@@ -2,12 +2,12 @@ apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- ../base
- https://github.com/redhat-appstudio/image-controller/config/default?ref=e5a29db5772c85b84d3246597e5b39f229d2925a
- https://github.com/redhat-appstudio/image-controller/config/default?ref=0f0b61cef9f667bb8a93d79fc03554fff9bb335b

images:
- name: quay.io/redhat-appstudio/image-controller
newName: quay.io/redhat-appstudio/image-controller
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mshaposhnik the image ref probably needs to be updated according to this

Copy link
Member

@mmorhun mmorhun Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to use released image on dev & stage, so it shouldn't be changed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok so I guess release is probably not working well? since CI is failing due to quay.io/redhat-appstudio/image-controller not containing the required SHA

last time a tag was pushed to this repo was 22 days ago
Screenshot 2024-04-25 at 14 47 56

Signed-off-by: Max Shaposhnyk <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Apr 26, 2024
Copy link

openshift-ci bot commented Apr 26, 2024

New changes are detected. LGTM label has been removed.

@mshaposhnik
Copy link
Contributor Author

/retest

1 similar comment
@mshaposhnik
Copy link
Contributor Author

/retest

@mshaposhnik mshaposhnik merged commit bae9ded into redhat-appstudio:main Apr 26, 2024
8 checks passed
@mshaposhnik mshaposhnik deleted the image-contoller-24-04 branch September 10, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants