-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix crashing app when deleting #1202
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1202 +/- ##
=======================================
Coverage 44.10% 44.10%
=======================================
Files 177 177
Lines 4501 4501
Branches 1007 1007
=======================================
Hits 1985 1985
Misses 2505 2505
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ibolton336 , it fixes the application from crashing meanwhile the application detail panel is still displaying the application details although the application doesn't exist anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ibolton, works fine now, just a detail, don't we want to make the refetch() statement last, after the detail drawer is gone ?
Signed-off-by: ibolton336 <[email protected]>
Resolves https://issues.redhat.com/browse/MTA-1041 Signed-off-by: ibolton336 <[email protected]>
Resolves https://issues.redhat.com/browse/MTA-1041 Signed-off-by: ibolton336 <[email protected]>
Resolves https://issues.redhat.com/browse/MTA-1041