Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix crashing app when deleting #1202

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Conversation

ibolton336
Copy link
Member

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c3917e9) 44.10% compared to head (7debb1f) 44.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1202   +/-   ##
=======================================
  Coverage   44.10%   44.10%           
=======================================
  Files         177      177           
  Lines        4501     4501           
  Branches     1007     1007           
=======================================
  Hits         1985     1985           
  Misses       2505     2505           
  Partials       11       11           
Flag Coverage Δ
unitests 44.10% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
client/src/app/queries/assessments.ts 17.85% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gildub gildub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibolton336 , it fixes the application from crashing meanwhile the application detail panel is still displaying the application details although the application doesn't exist anymore.

Copy link
Contributor

@gildub gildub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibolton, works fine now, just a detail, don't we want to make the refetch() statement last, after the detail drawer is gone ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants