🐛 Fix application edit data source #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: konveyor#2007 Summary of changes: - The application edit form needs to use the base `Application` data and not the `DecoratedApplication` as its basis for generating an update request. Extra information added by the decoration will be unknown to the hub endpoint and will cause issues. - All references to `Application` in the application table code have been updated to `DecoratedApplication` - Any adjustments needed when a `DecoratedApplication` is passed to a child component as an `Application` have been made - The dereferencing part of decoration has been moved to a `direct` container. This will allow the reuse of the `Application`` property name without replacing it. Signed-off-by: Scott J Dickerson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2008 +/- ##
==========================================
+ Coverage 39.20% 42.19% +2.99%
==========================================
Files 146 171 +25
Lines 4857 5479 +622
Branches 1164 1309 +145
==========================================
+ Hits 1904 2312 +408
- Misses 2939 3151 +212
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rszwajko
approved these changes
Jul 11, 2024
This was referenced Jul 17, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2007
Resolves: https://issues.redhat.com/browse/MTA-3232
Summary of changes:
The application edit form needs to use the base
Applicationdata and not theDecoratedApplicationas its basis for generating an update request. Extra information added by the decoration will be unknown to the hub endpoint and will cause issues.All references to
Applicationin the application table code have been updated toDecoratedApplicationAny adjustments needed when a
DecoratedApplicationis passed to a child component as anApplicationhave been madeThe dereferencing part of decoration has been moved to a
directcontainer. This will allow the reuse of theApplicationproperty name without replacing it.