Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix application edit data source #2008

Merged
merged 2 commits into from
Jul 11, 2024
Merged

🐛 Fix application edit data source #2008

merged 2 commits into from
Jul 11, 2024

Commits on Jul 11, 2024

  1. 🐛 Fix application edit data source 

    Resolves: konveyor#2007

Summary of changes:
  - The application edit form needs to use the base
    `Application` data and not the `DecoratedApplication`
    as its basis for generating an update request.  Extra
    information added by the decoration will be unknown
    to the hub endpoint and will cause issues.

  - All references to `Application` in the application
    table code have been updated to `DecoratedApplication`

  - Any adjustments needed when a `DecoratedApplication` is
    passed to a child component as an `Application` have
    been made

  - The dereferencing part of decoration has been moved to
    a `direct` container.  This will allow the reuse of the
    `Application`` property name without replacing it.

Signed-off-by: Scott J Dickerson <[email protected]>
    @sjd78
    sjd78 committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    ce80306 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into app-edit

    @sjd78
    sjd78 authored Jul 11, 2024
    Configuration menu
    Copy the full SHA
    ec3b308 View commit details
    Browse the repository at this point in the history