Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Don't use "mvn://::" for an empty binary source in applications #2015

Merged
merged 1 commit into from
Jul 15, 2024
Merged

🐛 Don't use "mvn://::" for an empty binary source in applications #2015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions client/src/app/pages/applications/components/application-form/application-form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,12 +263,12 @@ export const useApplicationFormHook = ({
});

const onValidSubmit = (formValues: FormValues) => {
let binaryValue = formValues.packaging
? `${formValues.group}:${formValues.artifact}:${formValues.version}:${formValues.packaging}`
: `${formValues.group}:${formValues.artifact}:${formValues.version}`;
if (!binaryValue.startsWith("mvn://")) {
binaryValue = `mvn://${binaryValue}`;
}
const binaryValues = [
formValues.group,
formValues.artifact,
formValues.version,
formValues.packaging,
].filter(Boolean);

const payload: New<Application> = {
name: formValues.name.trim(),
Expand All @@ -294,7 +294,8 @@ export const useApplicationFormHook = ({
path: formValues.rootPath.trim(),
}
: undefined,
binary: binaryValue,
binary:
binaryValues.length > 0 ? `mvn://${binaryValues.join(":")}` : undefined,

// Values not editable on the form but still need to be passed through
identities: application?.identities ?? undefined,
Expand Down
Loading