🐛 Don't use "mvn://::" for an empty binary source in applications #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating an application, if the "Binary (Java)" source is not specified, we want to store an empty string as the `binary` value and not `"mvn://::`. This also applied to editing an existing application. Signed-off-by: Scott J Dickerson <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2015 +/- ##
==========================================
+ Coverage 39.20% 42.22% +3.01%
==========================================
Files 146 171 +25
Lines 4857 5476 +619
Branches 1164 1351 +187
==========================================
+ Hits 1904 2312 +408
- Misses 2939 3048 +109
- Partials 14 116 +102
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ibolton336
approved these changes
Jul 15, 2024
This was referenced Jul 17, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating an application, if the "Binary (Java)" source is not specified, we want to store an empty string as the
binaryvalue and not"mvn://::. This also applied to editing an existing application.Resolves: #2014
Resolves: https://issues.redhat.com/browse/MTA-3238