✨ Use InfiniteScroller pattern for the Task Drawer #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2049 +/- ##
==========================================
+ Coverage 39.20% 42.15% +2.95%
==========================================
Files 146 174 +28
Lines 4857 5577 +720
Branches 1164 1376 +212
==========================================
+ Hits 1904 2351 +447
- Misses 2939 3210 +271
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rszwajko
force-pushed
the
infiniteScroller
branch
from
5e72edd
to
f6ed149
Compare
Infinite scroller inside Task Drawer(queries with 2 sec delay to show loading progress) Screencast.from.2024-08-14.20-36-24.mp4 |
rszwajko
force-pushed
the
infiniteScroller
branch
from
b74b3c2
to
ef89747
Compare
Implement InfiniteScroller based on oVirt VmPortal implementation and use it to fetch additional tasks in the Task Drawer. Key features: 1. fetch data using useInfiniteQuery from React Query 2. track sentinel visibility using IntersectionObserver API 3. monitor item count to prevent extra fetchMore calls Reference-Url: https://github.com/oVirt/ovirt-web-ui/blob/dfe0c4b8c92638f6e41b9fe0b09e0d07509618ae/src/components/VmsList/index.js#L50 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
rszwajko
force-pushed
the
infiniteScroller
branch
from
ef89747
to
a326194
Compare
rszwajko
changed the title
|
@sjd78 @ibolton336 |
sjd78
reviewed
Sep 4, 2024
client/src/app/components/InfiniteScroller/InfiniteScroller.tsx
Outdated
Show resolved
Hide resolved
client/src/app/components/InfiniteScroller/useVisibilityTracker.tsx
Outdated
Show resolved
Hide resolved
…r.tsx Co-authored-by: Scott Dickerson <[email protected]> Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
|
@sjd78 @ibolton336 |
sjd78
added a commit
that referenced
this pull request
Sep 14, 2024
Fixes: 1. initial delay in first fetch - root cause was delayed initialization of sentinel reference 2. extra page fetch request - algorithm based on items count was not sufficient Reference-Url: #2049 Signed-off-by: Radoslaw Szwajkowski <[email protected]> Co-authored-by: Scott Dickerson <[email protected]>
Shevijacobson
pushed a commit
to Shevijacobson/tackle2-ui
that referenced
this pull request
Sep 18, 2024
Fixes: 1. initial delay in first fetch - root cause was delayed initialization of sentinel reference 2. extra page fetch request - algorithm based on items count was not sufficient Reference-Url: konveyor#2049 Signed-off-by: Radoslaw Szwajkowski <[email protected]> Co-authored-by: Scott Dickerson <[email protected]>
Shevijacobson
pushed a commit
to Shevijacobson/tackle2-ui
that referenced
this pull request
Sep 18, 2024
Fixes: 1. initial delay in first fetch - root cause was delayed initialization of sentinel reference 2. extra page fetch request - algorithm based on items count was not sufficient Reference-Url: konveyor#2049 Signed-off-by: Radoslaw Szwajkowski <[email protected]> Co-authored-by: Scott Dickerson <[email protected]> Signed-off-by: Shevijacobson <[email protected]>
DvoraShechter1
pushed a commit
to DvoraShechter1/tackle2-ui
that referenced
this pull request
Sep 19, 2024
Fixes: 1. initial delay in first fetch - root cause was delayed initialization of sentinel reference 2. extra page fetch request - algorithm based on items count was not sufficient Reference-Url: konveyor#2049 Signed-off-by: Radoslaw Szwajkowski <[email protected]> Co-authored-by: Scott Dickerson <[email protected]> Signed-off-by: DvoraShechter1 <[email protected]>
DvoraShechter1
pushed a commit
to DvoraShechter1/tackle2-ui
that referenced
this pull request
Sep 19, 2024
Fixes: 1. initial delay in first fetch - root cause was delayed initialization of sentinel reference 2. extra page fetch request - algorithm based on items count was not sufficient Reference-Url: konveyor#2049 Signed-off-by: Radoslaw Szwajkowski <[email protected]> Co-authored-by: Scott Dickerson <[email protected]> Signed-off-by: DvoraShechter1 <[email protected]>
HadasahR
pushed a commit
to HadasahR/tackle2-ui
that referenced
this pull request
Sep 24, 2024
Fixes: 1. initial delay in first fetch - root cause was delayed initialization of sentinel reference 2. extra page fetch request - algorithm based on items count was not sufficient Reference-Url: konveyor#2049 Signed-off-by: Radoslaw Szwajkowski <[email protected]> Co-authored-by: Scott Dickerson <[email protected]> Signed-off-by: HadasahR <[email protected]>
This was referenced Oct 1, 2024
DvoraShechter1
pushed a commit
to DvoraShechter1/tackle2-ui
that referenced
this pull request
Oct 28, 2024
Fixes: 1. initial delay in first fetch - root cause was delayed initialization of sentinel reference 2. extra page fetch request - algorithm based on items count was not sufficient Reference-Url: konveyor#2049 Signed-off-by: Radoslaw Szwajkowski <[email protected]> Co-authored-by: Scott Dickerson <[email protected]>
sarinailinger
pushed a commit
to sarinailinger/tackle2-ui
that referenced
this pull request
Oct 30, 2024
Fixes: 1. initial delay in first fetch - root cause was delayed initialization of sentinel reference 2. extra page fetch request - algorithm based on items count was not sufficient Reference-Url: konveyor#2049 Signed-off-by: Radoslaw Szwajkowski <[email protected]> Co-authored-by: Scott Dickerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement InfiniteScroller based on oVirt VmPortal implementation and
use it to fetch additional tasks in the Task Drawer.
Key features:
Resolves: #1973
Reference-Url: https://github.com/oVirt/ovirt-web-ui/blob/dfe0c4b8c92638f6e41b9fe0b09e0d07509618ae/src/components/VmsList/index.js#L50
Signed-off-by: Radoslaw Szwajkowski [email protected]