Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Use InfiniteScroller pattern for the Task Drawer #2049

Merged
merged 5 commits into from
Sep 9, 2024
Merged

✨ Use InfiniteScroller pattern for the Task Drawer #2049

merged 5 commits into from
Sep 9, 2024

Commits on Sep 3, 2024

  1. Use InfiniteScroller pattern for the Task Drawer 

    Implement InfiniteScroller based on oVirt VmPortal implementation and
use it to fetch additional tasks in the Task Drawer.
Key features:
1. fetch data using useInfiniteQuery from React Query
2. track sentinel visibility using IntersectionObserver API
3. monitor item count to prevent extra fetchMore calls

Reference-Url: https://github.com/oVirt/ovirt-web-ui/blob/dfe0c4b8c92638f6e41b9fe0b09e0d07509618ae/src/components/VmsList/index.js#L50
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
    @rszwajko
    rszwajko committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    a326194 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Update client/src/app/components/InfiniteScroller/useVisibilityTracke… 

    …r.tsx

Co-authored-by: Scott Dickerson <[email protected]>
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
    @rszwajko @sjd78
    rszwajko and sjd78 authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    681394d View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into infiniteScroller

    @rszwajko
    rszwajko committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    5ad5d27 View commit details
    Browse the repository at this point in the history

  3. Remove extra logs, add setVisibleSafe wrapper for extra safety 

    Signed-off-by: Radoslaw Szwajkowski <[email protected]>
    @rszwajko
    rszwajko committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    a7af822 View commit details
    Browse the repository at this point in the history

  4. Change page saize to 20 

    Signed-off-by: Radoslaw Szwajkowski <[email protected]>
    @rszwajko
    rszwajko committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    d54892f View commit details
    Browse the repository at this point in the history