UI: Refactor Text component and typography handling #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ksharma-xyz
changed the title
use composition local, if it is not specified, then use the color provided otherwise fallback on the onSurface
ksharma-xyz
changed the title
Merge activity
|
ksharma-xyz
deleted the
02-06-text_should_repect_style_of_localtextstyle_composition_local_provider
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Improved text style handling and simplified Text component parameters.
What changed?
fontFamilyparameter from Text component overloadLocalTextColorwith fallback to theme'sonSurfacecolortextStyleandtextColorvariables for clearer style compositioncopy()for more explicit property updatesWhy make this change?
When the Text API is used inside a Button, it will provide a composition local style for text and color, which should be respected by the Text component. However, Text can also be used independently, requiring a style parameter. If we provide a style parameter, users might misuse it within a Button. To address this, we are merging and giving higher priority to the composition local text and color styles, then falling back to the provided parameters. This ensures consistency and prevents misuse.