UI: Add LocalTextColor provider to AnimatedLetter component #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksharma-xyz
changed the title
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ksharma-xyz
changed the base branch from
02-06-text_should_repect_style_of_localtextstyle_composition_local_provider
to
graphite-base/586
ksharma-xyz
force-pushed
the
graphite-base/586
branch
from
606e846 to
9ec4897
Compare
ksharma-xyz
force-pushed
the
02-06-fix_logo_color_on_app_start
branch
from
d4a2c0d to
778b1d7
Compare
ksharma-xyz
force-pushed
the
02-06-fix_logo_color_on_app_start
branch
from
778b1d7 to
c83c920
Compare
ksharma-xyz
force-pushed
the
02-06-fix_logo_color_on_app_start
branch
from
c83c920 to
3b4da77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added CompositionLocalProvider to set text color in the splash screen animation.
What changed?
Added a CompositionLocalProvider wrapper around the Text component in the AnimatedLetter composable to provide the logo color through LocalTextColor.
How to test?
Why make this change?
To maintain consistency with the app's text color management system by using CompositionLocalProvider instead of directly passing the color parameter. This ensures better theme management and makes the code more maintainable.