Uninstall Workflow #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll have a looky |
|
I can't see anything inherently wrong with the modifications, but do make sure to test (and not do a crowdstrike). |
toastxc
previously approved these changes
Jul 23, 2024
I tested it on W10 (w/ OF in the default sourcemod folder) last night, but I'll check it on my Debian install and my Steam Deck tonight. |
|
Tested on my windows install. Need to rebase from develop since #30 was merged. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
uninstallCLI sub-command and wizard option for uninstalling the target game. Before deleting the sourcemod mod folder, it will check if all of the following conditions are met;RunnerContext.current_version.is_some())crate::helper::is_game_runningwheremod_directoryis fromRunnerContext.get_mod_location())If any of those conditions are not met, an error will be returned and will not allowed the user to uninstall the game (if it is even installed).