-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 CI: default building kind node-images depending on KIND_BUILD_IMAGES env variable instead of ginkgo magic regexes #11784
🌱 CI: default building kind node-images depending on KIND_BUILD_IMAGES env variable instead of ginkgo magic regexes #11784
Conversation
/assign @sbueringer @fabriziopandini cc @cahillsf |
expected to fail, should get green after test-infra PR merge |
/lgtm |
LGTM label has been added. Git tree hash: c799164f4a08d3b92ed0417f22d362bee77f07c1
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…env variable instead of ginkgo magic regexes
6ade742
to
83f3a8f
Compare
/lgtm |
LGTM label has been added. Git tree hash: b4a114254cb70c53477ac87b8c3fe378088aa4f4
|
/test help |
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-cluster-api-e2e-blocking-main |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it:
Removes the magic matching on GINKGO_FOCUS and GINKGO_SKIP for defaulting vars for building kind node images.
Instead we now explicitly mention which variables to default on a per-job base in test-infra and pass it as envvar.
Needs the following PR to merge first:
/hold
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
/area ci