Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPI: add KIND_BUILD_IMAGES variable where no version env vars are set #34252

Merged
merged 2 commits into from
Feb 3, 2025
Merged

CAPI: add KIND_BUILD_IMAGES variable where no version env vars are set #34252

merged 2 commits into from
Feb 3, 2025
+135 −55

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented Feb 3, 2025 •
edited
Loading

More context at: kubernetes-sigs/cluster-api#11784

Required to merge before CAPI PR.

Note: also some cleanup in the second commit.

Note2: I on purpose did not set the variable on jobs where we already set the relevant KUBERNETES_ variables.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/jobs sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Feb 3, 2025
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Feb 3, 2025
@chrischdi
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2025
@chrischdi chrischdi mentioned this pull request Feb 3, 2025
Merged
@chrischdi
Copy link
Member Author

/assign @sbueringer @fabriziopandini

@chrischdi chrischdi mentioned this pull request Feb 3, 2025
Open
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrischdi
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit dccfdb8 into kubernetes:master Feb 3, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@chrischdi: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-main-periodics.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-main-periodics.yaml
  • key cluster-api-main-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-main-presubmits.yaml
  • key cluster-api-release-1-7-periodics.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-release-1-7-periodics.yaml
  • key cluster-api-release-1-7-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-release-1-7-presubmits.yaml
  • key cluster-api-release-1-8-periodics.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-release-1-8-periodics.yaml
  • key cluster-api-release-1-8-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-release-1-8-presubmits.yaml
  • key cluster-api-release-1-9-periodics.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-release-1-9-periodics.yaml
  • key cluster-api-release-1-9-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-release-1-9-presubmits.yaml

In response to this:

More context at: kubernetes-sigs/cluster-api#11784

Required to merge before CAPI PR.

Note: also some cleanup in the second commit.

Note2: I on purpose did not set the variable on jobs where we already set the relevant KUBERNETES_ variables.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrischdi @sbueringer @k8s-ci-robot @fabriziopandini