Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ MOD: Add a new config in manager.New to set on stopped leading function #2862

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

✨ MOD: Add a new config in manager.New to set on stopped leading function #2862

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/manager/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import (
"k8s.io/client-go/tools/leaderelection/resourcelock"
"k8s.io/client-go/tools/record"
"k8s.io/utils/ptr"

metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"

"sigs.k8s.io/controller-runtime/pkg/cache"
Expand Down Expand Up @@ -201,6 +202,10 @@ type Options struct {
// LeaseDuration time first.
LeaderElectionReleaseOnCancel bool

// OnStoppedLeading is callled when the leader election lease is lost.
// It can be overridden for tests.
OnStoppedLeading func()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just run this after the manager ended to achieve the same result or not?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lost leader is not equal manager ended. so we can't do that in operator's preStop or other hook.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference? The manager ends after it lost the leader?


// LeaderElectionResourceLockInterface allows to provide a custom resourcelock.Interface that was created outside
// of the controller-runtime. If this value is set the options LeaderElectionID, LeaderElectionNamespace,
// LeaderElectionResourceLock, LeaseDuration, RenewDeadline and RetryPeriod will be ignored. This can be useful if you
Expand Down Expand Up @@ -441,6 +446,7 @@ func New(config *rest.Config, options Options) (Manager, error) {
internalProceduresStop: make(chan struct{}),
leaderElectionStopped: make(chan struct{}),
leaderElectionReleaseOnCancel: options.LeaderElectionReleaseOnCancel,
onStoppedLeading: options.OnStoppedLeading,
}, nil
}

Expand Down
Loading