-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'book-v4' into book-v4-release-branch
- Loading branch information
Showing
1 changed file
with
5 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # Metrics | ||
|
|
||
| By default, controller-runtime builds a global prometheus registry and | ||
| By default, controller-runtime builds a global Prometheus registry and | ||
| publishes [a collection of performance metrics](/reference/metrics-reference.md) for each controller. | ||
|
|
||
|
|
||
|
|
@@ -13,10 +13,10 @@ Your projects will be affected and may fail to work if the image cannot be pulle | |
| **Images provided under `gcr.io/kubebuilder/` will be unavailable from early 2025.** | ||
|
|
||
| - **Projects initialized with Kubebuilder versions `v3.14` or lower** utilize [kube-rbac-proxy](https://github.com/brancz/kube-rbac-proxy) to protect the metrics endpoint. | ||
| In this case, you might want to upgrade your project to the latest release or ensure that you have applied the same or similar code changes. | ||
| In this case, you might want to upgrade your project to the latest release or ensure that you have applied the same or similar code changes. | ||
|
|
||
| - **However, projects initialized with Kubebuilder versions `v4.1.0` or higher** have similar protection using `authn/authz` | ||
| enabled by default via Controller-Runtime's feature [WithAuthenticationAndAuthorization](https://pkg.go.dev/sigs.k8s.io/[email protected]/pkg/metrics/filters#WithAuthenticationAndAuthorization). | ||
| enabled by default via Controller-Runtime's feature [WithAuthenticationAndAuthorization](https://pkg.go.dev/sigs.k8s.io/[email protected]/pkg/metrics/filters#WithAuthenticationAndAuthorization). | ||
|
|
||
| If you want to continue using [kube-rbac-proxy](https://github.com/brancz/kube-rbac-proxy) then you MUST change | ||
| your project to use the image from another source. | ||
|
|
@@ -25,6 +25,7 @@ your project to use the image from another source. | |
| </aside> | ||
|
|
||
|
|
||
| ## Metrics Configuration | ||
|
|
||
| By looking at the file `config/default/kustomization.yaml` you can | ||
|
|
@@ -369,4 +370,4 @@ particularly during critical periods when monitoring and diagnosing issues in re | |
|
|
||
| An [issue](https://github.com/kubernetes-sigs/controller-runtime/issues/2781) has been opened to | ||
| enhance the controller-runtime and address these considerations. | ||
| </aside> | ||
| </aside> | ||