-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt checksums and versions to new hashes updater #11890
base: master
Are you sure you want to change the base?
Adapt checksums and versions to new hashes updater #11890
Conversation
/ok-to-test
|
/label ci/extended |
@VannTen: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/label tide/merge-method-merge |
/label ci-extended |
/retest |
59e8f8f
to
b2e8473
Compare
b2e8473
to
0b9d9bb
Compare
bce30fc
to
2d64093
Compare
6d54849
to
6619a62
Compare
a3e081f
to
815bc6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @VannTen
It's a break change :-) |
I did (with the `action required`). Or maybe you meant something else ?
|
815bc6e
to
e60f68f
Compare
Hum, what do you think regarding the README versions ? Should we keep a leading v here or use the same consistency and get rid of it ? Now that I'm writing it it seems the 2nd option seems to make more sense (I don't care much though, can change if needed) |
Hello @VannTen , This change may cause errors for users who are currently using Kubespray, especially those who use the It would be more user-friendly for existing users if we could provide compatibility with the previous |
I considered doing that. |
Because many existing clusters require maintenance, the compatibility may need to be maintained. It may be solved in another PR later. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mzaian, VannTen, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Because many existing clusters require maintenance, the compatibility may need to be maintained.
To put thing in perspective, that really does not need much, just removing 'v' from explicit version defined in your inventory.
That looks like a 'less than 5 minutes' change to me, which is why I've done it this way.
It's possible to maintain compat with version stating with 'v', but I don't think it's worth the extra variable massaging in kubespray.
|
With the refactored script, this would try to download those releases each time.
The versions are nearly all .0 because of the gvisor release scheme. This means they need to be quoted in yaml to be considered strings. Special casing by removing the .0 make tooling more complicated, and it does not gain us anything apart from a nicer looking file (I guess). So just use the version of upstream gvisor and quote it.
also remove the version key in all dict in downloads since it's not used anywhere.
Allow the use of different hashes, as support by the get_url Ansible module. Change the variable name accordingly to 'checksum' since it's not exclusively sha256 anymore.
Only check version that we previously prefixed with 'v'. This commit should be reverted as soon as 2.28 is released.
Also small spacing fix.
f07ec1d
to
8a10d55
Compare
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This (WIP) adapt Kubespray checksums and version to work with the new hashes updater.
I'm pushing this as draft so reviewers of the hashes updaters can test it.
This is pretty invasive, as you can see, mostly because of removing the v-prefix in version (this originates from the design of the updater script, but I've been going with it for consistency).
Which issue(s) this PR fixes:
Special notes for your reviewer:
I'm putting this as ci/extended to avoid breaking stuff
This might be hard to backport, which might preclude automatic PR for hash updates on the (current) releases branches.
Does this PR introduce a user-facing change?: