-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable containerd test-handler runtimeclass for k/k e2e tests #16056
Conversation
2fe358f
to
b5a64a9
Compare
/test pull-kops-kubernetes-e2e-cos-gce |
b5a64a9
to
9982e0f
Compare
010544f
to
6e4b84d
Compare
/test pull-kops-kubernetes-e2e-cos-gce-serial |
6e4b84d
to
b1d4ad2
Compare
We do. Fixed the diff |
b1d4ad2
to
d187b57
Compare
f4df15d
to
3dc27ef
Compare
3dc27ef
to
8f749a5
Compare
I think it's a cobra / viper bug. It doesn't allow for quotes in a string slice var... I think we may be able to work around by using our own string slice parser in cobra, I'll take a look |
Ah, and it's been reported upstream but not fixed: spf13/pflag#370 |
Hoping that #16125 will allow for writing this naturally e.g.
|
8511727
to
99b5fdf
Compare
/test pull-kops-kubernetes-e2e-cos-gce-serial |
@upodroid: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
99b5fdf
to
9041159
Compare
This is ready to be merged now @hakman |
9041159
to
a09dc4c
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Some k/k e2e tests require the test-handler RuntimeClass to be configured.
https://testgrid.k8s.io/sig-cluster-lifecycle-kubeup-to-kops#ci-kubernetes-e2e-cos-gce-canary&include-filter-by-regex=RuntimeClass
https://testgrid.k8s.io/sig-cluster-lifecycle-kubeup-to-kops#ci-kubernetes-e2e-cos-gce-serial-canary&include-filter-by-regex=RuntimeClass
Tests got skipped because it is missing.
kubeup behaviour:
https://github.com/kubernetes/kubernetes/blob/9ae55e98868d78a7103358e1feb7d15b8403d0fa/cluster/gce/gci/configure-helper.sh#L3225