Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error notifications for better UX #31

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

f1ames
Copy link
Contributor

@f1ames f1ames commented Aug 18, 2023

This PR fixes #28.

It based on #25 branch so needs to be merged after that one.

There are few related, follow-up issues to help with better on-boarding and fixing invalid configuration - #27, #30 and kubeshop/monokle-core#483.

Changes

Fixes

  • Now, notifications will not be shown on every policy pull which errors (due to any reason). Instead, status bar icon changes it's state and shows error details and possible fix suggestion (for specific cases which we know how to fix).

image

Remarks

  • Kind of quick fix, so the tooltip status management is a bit too fragmented in different places. At first it was very simple util, now it's more like global status holder/provider. May need a bit of refactoring in the future.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@f1ames f1ames force-pushed the f1ames/fix/28-error-improvements branch from 35fda66 to 012a58a Compare August 18, 2023 09:48
@f1ames f1ames marked this pull request as ready for review August 18, 2023 09:48
Base automatically changed from f1ames/feat/device-flow to main August 21, 2023 14:36
@f1ames f1ames mentioned this pull request Aug 21, 2023
4 tasks
@f1ames f1ames force-pushed the f1ames/fix/28-error-improvements branch from 012a58a to 86141fb Compare August 21, 2023 14:50
@f1ames
Copy link
Contributor Author

f1ames commented Aug 21, 2023

Rebased onto latest main.

@f1ames f1ames force-pushed the f1ames/fix/28-error-improvements branch from a15285e to 9bf5849 Compare August 22, 2023 10:22
@f1ames f1ames merged commit fe7154f into main Aug 22, 2023
@f1ames f1ames deleted the f1ames/fix/28-error-improvements branch August 22, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix error handling notifications
2 participants