Adding monitoring orchestration in the operator to collect metrics for Telemetry.

[bkhizgiy]

Following the addition of metrics to forklift-controller, this PR adds monitoring orchestration to add the ability to collect data and expose it for OpenShift-Monitor. These changes include the addition of different resources such as Service, the ServiceMonitor, and various labels needed for the metrics collection.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.83%. Comparing base (50a2566) to head (1bd761f).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #932   +/-   ##
=======================================
  Coverage   15.83%   15.83%           
=======================================
  Files         108      108           
  Lines       19911    19911           
=======================================
  Hits         3153     3153           
  Misses      16479    16479           
  Partials      279      279           

Flag	Coverage Δ
unittests	15.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[liranr23]

since you removed this. did you check if now you need the permissions and monitor.yaml within the operator(operator/config/prometheus/monitor.yaml and within operator/config/rbac/leader_election_role.yaml)?

[bkhizgiy]

I didn't removed it, I just moved it to the monitor directory to have all the monitoring related things organized in the same place, but any way the yaml you referring is not related to the controller metrics (i'm not sure for what it used), but it configured on a different namespace and port. i'm creating the relevant file for the metric recording in the controller addition.

[bkhizgiy]

CI issue was fixed, CR changes in progress.

[bkhizgiy]

Remove all the rules setup since it is redundant, and move all the monitoring orchestration under metrics. This should simplify the PR. It was tested on OpenShift to ensure all the metrics are exposed.

[bkhizgiy]

PR was rebased after merging #916.

[ahadas]

Following the addition of metrics to forklift-controller, this PR adds monitoring orchestration to add the ability to collected data and expose it for OpenShift-Monitor. These changes include the addition of different resources such as Service, the ServiceMonitor, and various labels needed for the metrics collection.

to collect data*

[ahadas]

why do we let forklift-controller add the metrics-related resources rather than the operator?

[bkhizgiy]

Moved all the relevant resource creation for monitoring to be managed by the operator rather than the controller.

[ahadas]

minor comment about phrasing inside, other than that lgtm