refactor: remove easyjson dependency #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
flavio
reviewed
Jul 28, 2023
settings.go
Outdated
Comment on lines
14
to
18
| type RawSettings struct { | ||
| DeniedLabels []string `json:"denied_labels"` | ||
| MandatoryLabels []string `json:"mandatory_labels"` | ||
| ConstrainedLabels map[string]string `json:"constrained_labels"` | ||
| } |
There was a problem hiding this comment.
We should merge RawSettings with Settings, this was just a workaround caused by easyjson not supporting properly mapset. Can you give a shot at unmarshalling the json straight into Settings?
There was a problem hiding this comment.
refactored in: 2fd4d59
Implemented json.Unmarshaler for Settings, but kept an anonymous struct similar to RawSettingsto simplify the unmarshalling.
viccuad
approved these changes
Jul 28, 2023
Signed-off-by: Fabrizio Sestito <[email protected]>
fabriziosestito
force-pushed
the
refactor/remove-easyjson
branch
from
b4b836f
to
c322882
Compare
fabriziosestito
force-pushed
the
refactor/remove-easyjson
branch
from
c322882
to
2fd4d59
Compare
flavio
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the easyjson dependency by bumping
policy-sdkto the latest version.Test
Existing tests should pass.
Additional Information
Artifact hub configuration was updated.
Related to: kubewarden/kubewarden-controller#492