Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop module condition metrics #2188

Conversation

amritanshusikdar
Copy link
Contributor

Description
Resolves #2073

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. labels Jan 17, 2025
@amritanshusikdar amritanshusikdar marked this pull request as ready for review January 17, 2025 09:44
@amritanshusikdar amritanshusikdar requested a review from a team as a code owner January 17, 2025 09:44
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 17, 2025
@amritanshusikdar amritanshusikdar force-pushed the drop_module_condition_metrics branch from a2e3ae1 to 4a3cfab Compare January 17, 2025 11:33
@amritanshusikdar amritanshusikdar changed the title fix: Drop module condition metrics chore: Drop module condition metrics Jan 17, 2025
@amritanshusikdar amritanshusikdar force-pushed the drop_module_condition_metrics branch 3 times, most recently from f7fb0af to 6b134c6 Compare January 17, 2025 16:50
nesmabadr
nesmabadr previously approved these changes Jan 20, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 20, 2025
@nesmabadr nesmabadr self-requested a review January 20, 2025 11:50
@nesmabadr
Copy link
Contributor

Please adjust the unit test coverage

@amritanshusikdar amritanshusikdar force-pushed the drop_module_condition_metrics branch from 6b134c6 to 2f74c75 Compare January 20, 2025 12:00
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 20, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 20, 2025
@amritanshusikdar amritanshusikdar merged commit 9d7efc4 into kyma-project:main Jan 20, 2025
68 of 69 checks passed
@amritanshusikdar amritanshusikdar deleted the drop_module_condition_metrics branch January 20, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop the lifecycle_mgr_module_condition metrics and warning condition
3 participants