Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement MaintenanceWindow determination logic #2196

Merged
merged 18 commits into from
Jan 20, 2025
Merged

feat: Implement MaintenanceWindow determination logic #2196

merged 18 commits into from
Jan 20, 2025

Conversation

c-pius
Copy link
Contributor

@c-pius c-pius commented Jan 20, 2025

Description

Changes proposed in this pull request:

  • adds the logic to determine if a maintenance window is required and active
  • passes this implementation to the template lookup where it will be used
    • it is not used yet, just passed
    • in the next PR, we will make use of this new functionality

Related issue(s)

c-pius and others added 10 commits January 17, 2025 14:08
@c-pius
feat: Add metadata and status helpers to Kyma type
be93b37
@c-pius
add go sum
67e281c
@c-pius
cleanup go mod, add api to coverage
62e085b
@c-pius
remove api from unit-test coverage
18e63de
@c-pius
feat: MaintenanceWindow service
2558523
@dependabot @c-pius
chore(dependabot): bump k8s.io/apimachinery from 0.32.0 to 0.32.1 in …
f5af4d7 
…/api (kyma-project#2185)

chore(dependabot): bump k8s.io/apimachinery in /api

Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.32.0 to 0.32.1.
- [Commits](kubernetes/apimachinery@v0.32.0...v0.32.1)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @c-pius
chore(dependabot): bump sigs.k8s.io/controller-runtime from 0.19.4 to…
8cb7ca0 
… 0.20.0 (kyma-project#2192)

chore(dependabot): bump sigs.k8s.io/controller-runtime

Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.19.4 to 0.20.0.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.19.4...v0.20.0)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@c-pius
feat: Add metadata and status helpers to Kyma type
36c0e7b
@c-pius
cleanup go mod, add api to coverage
d2c912b
@c-pius
Merge branch 'kyma-project:main' into feat/maintenance-window-determi…
6108a63 
…nation
@c-pius c-pius requested a review from a team as a code owner January 20, 2025 07:58
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 20, 2025
@c-pius c-pius linked an issue Jan 20, 2025 that may be closed by this pull request
[Maintenance Windows] Skip module upgrades during maintenance window #2101
Open
7 tasks
@lindnerby lindnerby self-assigned this Jan 20, 2025
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 20, 2025
@lindnerby lindnerby assigned LeelaChacha and unassigned lindnerby Jan 20, 2025
LeelaChacha
LeelaChacha requested changes Jan 20, 2025
View reviewed changes
tests/integration/controller/kyma/suite_test.go Outdated Show resolved Hide resolved
tests/integration/controller/kyma/suite_test.go Outdated Show resolved Hide resolved
cmd/main.go Show resolved Hide resolved
cmd/main.go Show resolved Hide resolved
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 20, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 20, 2025
@LeelaChacha LeelaChacha assigned c-pius and unassigned LeelaChacha Jan 20, 2025
@c-pius c-pius merged commit 90b9197 into kyma-project:main Jan 20, 2025
67 of 69 checks passed
@c-pius c-pius deleted the feat/maintenance-window-determination branch January 20, 2025 16:16
c-pius added a commit to c-pius/lifecycle-manager that referenced this pull request Jan 21, 2025
@c-pius @dependabot
feat: Implement MaintenanceWindow determination logic (kyma-project#2196
5d6ce78 
)

* feat: Add metadata and status helpers to Kyma type

* add go sum

* cleanup go mod, add api to coverage

* remove api from unit-test coverage

* feat: MaintenanceWindow service

* chore(dependabot): bump k8s.io/apimachinery from 0.32.0 to 0.32.1 in /api (kyma-project#2185)

chore(dependabot): bump k8s.io/apimachinery in /api

Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.32.0 to 0.32.1.
- [Commits](kubernetes/apimachinery@v0.32.0...v0.32.1)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(dependabot): bump sigs.k8s.io/controller-runtime from 0.19.4 to 0.20.0 (kyma-project#2192)

chore(dependabot): bump sigs.k8s.io/controller-runtime

Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.19.4 to 0.20.0.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.19.4...v0.20.0)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: Add metadata and status helpers to Kyma type

* cleanup go mod, add api to coverage

* remove obsolete comment

* fix fake arguments in suite_test

* avoid handler name in suite_test

* rename to maintenanceWindow consistently

* underscore unused receiver arg

* omit receiver arg

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
c-pius added a commit that referenced this pull request Jan 22, 2025
@c-pius @amritanshusikdar
@dependabot @lindnerby @mmitoraj
docs: Update local-test-setup.md to use scripts (#2178)
1fd218e 
* docs: Update local-test-setup.md to use scripts

* Update docs/contributor/04-local-test-setup.md

* docs: Reference Mandatory Modules Controller in Architecture Docs (#2197)

* reference controller in architecture docs

* fix markdown lint

* improve docs

* feat: Implement MaintenanceWindow determination logic (#2196)

* feat: Add metadata and status helpers to Kyma type

* add go sum

* cleanup go mod, add api to coverage

* remove api from unit-test coverage

* feat: MaintenanceWindow service

* chore(dependabot): bump k8s.io/apimachinery from 0.32.0 to 0.32.1 in /api (#2185)

chore(dependabot): bump k8s.io/apimachinery in /api

Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.32.0 to 0.32.1.
- [Commits](kubernetes/apimachinery@v0.32.0...v0.32.1)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(dependabot): bump sigs.k8s.io/controller-runtime from 0.19.4 to 0.20.0 (#2192)

chore(dependabot): bump sigs.k8s.io/controller-runtime

Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.19.4 to 0.20.0.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](kubernetes-sigs/controller-runtime@v0.19.4...v0.20.0)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: Add metadata and status helpers to Kyma type

* cleanup go mod, add api to coverage

* remove obsolete comment

* fix fake arguments in suite_test

* avoid handler name in suite_test

* rename to maintenanceWindow consistently

* underscore unused receiver arg

* omit receiver arg

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* title numbering and casing

* Apply suggestions from code review

Co-authored-by: Małgorzata Świeca <[email protected]>

* Update docs/contributor/04-local-test-setup.md

* indent scripts

* link CRDs

* Update docs/contributor/04-local-test-setup.md

Co-authored-by: Małgorzata Świeca <[email protected]>

* Update docs/contributor/04-local-test-setup.md

Co-authored-by: Małgorzata Świeca <[email protected]>

* fix indentation

* fix indentation and numbering

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Amritanshu Sikdar <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Benjamin Lindner <[email protected]>
Co-authored-by: Małgorzata Świeca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindnerby lindnerby lindnerby left review comments

@LeelaChacha LeelaChacha LeelaChacha approved these changes

Assignees

@c-pius c-pius

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maintenance Windows] Skip module upgrades during maintenance window
4 participants
@c-pius @lindnerby @LeelaChacha @kyma-bot